Added provider-consumer example (multiple related packages). #245
Conversation
ericsnekbytes
changed the title
|
@jtpio This is pretty much done (minus some small formatting items and the signalling issue mentioned above) if you want to take a look. Keep in mind that this is intended to be a MINIMAL demonstration of the features needed to implement the provider-consumer pattern (I skipped over several opportunities to make it "better" in favor of highly reduced complexity). |
ericsnekbytes
changed the title
|
@fcollonval If you have time to review I'd like to get this approved, the Dual Compatibility document has a spinoff "Plugin System" document (see top post description) that depends on this example so this should be merged first. My plan now is to try to get the document and examples merged first, then do a follow-up PR for the unit tests and repo-referencing for the code snippets. |
| it('should be tested', () => { | ||
| expect(1 + 1).toEqual(2); | ||
| }); |
There was a problem hiding this comment.
Do you intend to implement the test here?
|
@ericsnekbytes does this work with jupyterlab 3? |
@terlan4 It does work in JupyterLab 3, just tested it. The Provider/Consumer pattern is a foundational piece of JupyterLab's design and of its extension system, (so it is certainly relevant to both). |
ericsnekbytes
added
documentation
|
Also running into this error, which seems to be successful but is returning a non-zero exit code:
|
This example adds three related extension packages:
With all 3 installed in a JupyterLab environment, users will get a provider extension that counts steps (a token + a default service implementation that holds step count data), and two alternate consumer plugins that consume the provider's step_counter service and provide disparate interactivity via buttons in each extension that count steps differently.